mirror/tor
0
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-20 20:23:03 +02:00
Code

Test: Fix memory leaks and missing unmocks in entry guard tests

Browse Source 
test_entry_guard_outdated_dirserver_exclusion leaks memory, and is
missing some unmocks.

Fixes 28554; bugfix on 0.3.0.1-alpha.
This commit is contained in:
teor 2018-11-21 15:56:30 +10:00
parent cbe04d4550
commit ffc7b81b5d
No known key found for this signature in database
GPG Key ID: 10FEAA0E7075672A
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changes/bug28554 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (unit tests, guard selection):
- Stop leaking memory in an entry guard unit test. Fixes bug 28554;
bugfix on 0.3.0.1-alpha.

5
src/test/test_entrynodes.c
View File

@ -2779,13 +2779,16 @@ test_entry_guard_outdated_dirserver_exclusion(void *arg)
digests, 3, 7, 0);
/* ... and check that because we failed to fetch microdescs from all our
* primaries, we didnt end up selecting a primary for fetching dir info */
* primaries, we didn't end up selecting a primary for fetching dir info */
expect_log_msg_containing("No primary or confirmed guards available.");
teardown_capture_of_logs();
}
done:
UNMOCK(networkstatus_get_latest_consensus_by_flavor);
UNMOCK(directory_initiate_request);
smartlist_free(digests);
tor_free(mock_ns_val);
tor_free(args);
if (conn) {
tor_free(conn->requested_resource);