- Since colIsOpen() is always true if its possible to open Collection..
- Maintains same behavior, but uses colIsOpen instead of getColSafe in:
- onPrepareOptionsMenu()
- onResume()
- Call displaySyncBadge from onCreateOptionsMenu() only if colIsOpen()
- No more predictable StorageAccessExceptions from getColSafe()
The conversion to variants in #8151 meant AnkiDroid did not have a valid
lintRelease target anymore so it was not running in CI as expected
Using the variant-specific name makes it work, and splitting the checks into
specific ones for each sub-module should make it obvious in the future if any
further variant-related work happens
Fixes#8669
It's especially important because it is a link entirely unrelated to the number it contains.
This should probably be removed, because it's confusing, not clear that clicking on number will do something specific,
nor what it will do. This is not only an accessibility question. In the meantime, describing seems better
I believe it is required because those numbers are not clear (actually, not clear even without context), and the top of
the column is not accessible as we are not using a table
Fix#8467: Prevent crash on long pressing an already selected card
We were incorrectly using .getChildAt() which returns the view
based on the visual position. Once we got past the end of the
first "page" of the list, we got a crash.
We now update the data, and have the adapter set the checked state
when the data comes into the foreground
Co-authored-by: Shridhar <shridhar.goel@gmail.com>
* Bump fragment from 1.3.2 to 1.3.3 (#320)
* Bump fragment-testing from 1.3.2 to 1.3.3 (#319)
* Bump mockito-inline from 3.8.0 to 3.9.0 (#318)
* chore: bump sqlite-android to 3.35.4, re-point upstream
Upstream is now off jcenter officially after collaboration + merge of:
https://github.com/requery/sqlite-android/pull/145
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* Test: Check if Illegal Characters at the start of Fields get handled
Co-authored-by: David Allison <62114487+david-allison-1@users.noreply.github.com>
* Created CreateDeckDialog class and ShowDialog Test
* replaced deck picker dialog code by CreateDeckDialog
* replaced DeckPickerFloatingAction dialog code by CreateDeckDialog
And extracted initialization code of NoteDeckSpinner to separate function
* Added Deck Create Function in DeckSelectionDialog
* optimized showFilteredDeckDialog fucntion from CreateDeckDialog
* NF: correct relocated method name in logging
* Refactor performClickWithAction to answerCard
* Remove all mentions of performClickWithVisual
* Add visual feedback to gestures and touch events
* Add back overridden method and some code formatting
* Cherry pick from revert-touch
* Replace touch handler with a class encompassing both click and touch handlers
* Fixing logic
* Fix lint
* Logic documentation
* Add documentation to click threshold constant
Co-authored-by: Mike Hardy <github@mikehardy.net>
* Test optimization
Co-authored-by: David Allison <62114487+david-allison-1@users.noreply.github.com>
Co-authored-by: Mike Hardy <github@mikehardy.net>
Main issue: we use the same list reference, leading to prefetched
cards bring added twice
The other issue was an off-by-one error in the count of cards to pre
render. This didn't matter too much, but we returned one more than was
requested
Fixes 8547
this is important because it is about to sunset, and if we do not
peel this off before we cut the release-2.15 branch, that branch
will no longer build without backporting
- API publishing needed a complete overhaul, tested locally, works
- JCenter is still needed for AnkiDroid as noted unfortunately...couple months to go
- Some artifact resolution performance complaints but local testing shows every single thing works
There was no reason to affect the whole note while only a card was changed. However, it was not a bug, even if it was
reverting siblings. Indeed, if this undo is executed, all changes made too siblings would have been undone previously
