It appears upstream has fixed the leak as of 0.45.0, so workaround
not needed, and ktlint is now on 0.45.2 anyway, so use that
Can't remove the actual version override that gets us 0.45.x until
the ktlint gradle plugin has a new release but that hasn't happened yet
Sometimes an emulator "runs" tests, but it actually discovered zero
tests, runs zero tests, and still reports success. Lookin' at you API21.
Fixes#11078
This should optimize LRU cache eviction so main and branches always have
reasonably fresh gradle caches and main does not ever get evicted, since
branches have independent caches and would otherwise fill up 10GB cache limit
Note that `--daemon` is specified as the default for this action is no daemon,
that is correct for long-lived runners to avoid cross-build contamination, but
on GitHub Hosted Runners (which we use) we are clean each run, so this is a small
optimization to share gradle between steps: https://github.com/gradle/gradle-build-action/issues/113#issuecomment-1003204780
chore(deps): bump kotlin_version from 1.6.20 to 1.6.21 c275b35
chore(deps): bump mockito-inline from 4.4.0 to 4.5.0 0eee1e6
chore(deps): bump leakcanary-android from 2.7 to 2.9 (#10988) 72bede3
chore(deps): bump protobuf-java from 3.20.0 to 3.20.1 e79c835
chore(deps): bump leakcanary-android from 2.9 to 2.9.1 674c833
chore(deps): bump mockito-inline from 4.5.0 to 4.5.1 e790731
build(deps): kotlin stdlib deps are implicit now #10991
Plurals missing positional string args were previously
not detected by either lint or AAPT2. A future PR will fix this
and the code needs to have no issues.
To fix: rename:
`reviewer_window_title_days` -> `reviewer_window_title_days_new`
`reviewer_window_title_hours` -> `reviewer_window_title_hours_new`
and fix the strings: `%d` -> `%1$d`
I renamed the strings as:
* This was easier to do in the IDE, rather than deleting them
* They'll be overwritten on the next translation sync
* and with less of a 'line change'
Issue 11072
Unblocks 11081 (adding the lint)
Part of issue #10489
Update AbstractFlashcardViewerTest.kt
Fix a code style problem.
update`AbstractFlashcardViewerTest.kt`. Apply parameterized tests
update`AbstractFlashcardViewerTest.kt`. Clean the code style
Change the input parameter to tuple to improve the readability of the code
format the code style
fix code style
tools:ignore ignores the outcome, but still processed the file
This caused a bug as it found a duplicate key in an ignored file
and flagged it as an error on the non-ignored file
Also adds an emulator run benchmarking suite that works in combo with matrix
If branch builds result in cache upload of emulator files the cache files there will
need to be scoped for just changes on the snapshot file(s)
DuplicateCrowdInStrings applies to only the /values/ folder
But there are other files in the values folder aside from translatable
strings (resources, constants, etc...)
As lint does not currently have a good way to exclude files from linting
So instead we use `tools:ignore` to do this
