0
0
mirror of https://github.com/ankidroid/Anki-Android.git synced 2024-09-20 12:02:16 +02:00
Commit Graph

11841 Commits

Author SHA1 Message Date
David Allison
6caf7a9be6 Duplicate CrowdIn Strings: Allow str with comment
If all instances of a string have comments - ignore it.

Related: 7582
2020-11-20 07:46:54 -05:00
David Allison
c51bbc004f NF: Duplicate CrowdIn Strings - Invert if
Massive improvement in readability

Related: 7582
2020-11-20 07:46:54 -05:00
David Allison
4c140c6f24 Duplicate CrowdIn Strings: Ignore translated
We only want to check and warn for duplicates in our new strings

Related: 7582
2020-11-20 07:46:54 -05:00
David Allison
60b7c8ec1d Add DuplicateCrowdInStrings lint check
Converted from Kotlin to Java from AOSP

Convert: StringCasingDetector.kt to java
Use methods from: StringFormatDetector.java

Related: 7582
2020-11-20 07:46:54 -05:00
David Allison
987ed42877 "Undo" feature: Fix race condition
There appears to be a race condition in LinkedList.unlinkFirst

A LinkedBlockingDeque should fix this

Fixes 7723
2020-11-20 07:40:01 -05:00
David Allison
c92b54faa7 Sched: Handle suspended cards in filtered decks
Suspended cards are now removed from the filtered decks when emptied/rebuilt
and stay suspended

Applies
fe493e31c4

https://anki.tenderapp.com/discussions/ankidesktop/38247-bug-suspended-cards-automatically-included-in-the-filtered-decks

Fixes 7730
2020-11-20 07:32:19 -05:00
David Allison
08667278e6 NF: Refactor Collection.cardCount
Change parameter name
Extract Collection.isEmptyDeck
Change to varargs
2020-11-20 07:32:19 -05:00
David Allison
50ff61b773 Add Keyboard shortcut: Check Pronunciation
Shift+V = Record Audio
V = Play Audio

Fixes 7732
2020-11-20 07:28:46 -05:00
Arthur Milchior
bcaad03cf2 NF: indicates clearly that markUndo takes NonNull 2020-11-20 11:31:55 +00:00
Mike Hardy
61c2bf0617 Bumped version to 2.15alpha6
@branch-specific
2020-11-20 03:32:17 +00:00
David Allison
5f05802735 Handle open URI failure
Fixes 7721
2020-11-19 09:54:52 -05:00
David Allison
241b59ceb7 AdaptionUtil: Ignore invalid browsers
Fixes 7721
2020-11-19 09:54:52 -05:00
David Allison
258a9caa46 resetPassword: use openUrl
This will allow us to add better validation

Related: 7721
2020-11-19 09:54:52 -05:00
Arthur Milchior
b592d2c33c NF: remove warning about raw parametrized type 2020-11-19 03:07:33 +00:00
Arthur Milchior
1bdd057c9e NF: calculateCardTypes always return false, never read. Removed 2020-11-19 02:22:25 +00:00
Arthur Milchior
c65544eb86 NF: remove unused constant getName 2020-11-19 02:22:25 +00:00
Arthur Milchior
7a8a1d4eb4 NF: getFont never called and always return null. Delete 2020-11-19 02:22:25 +00:00
Arthur Milchior
ca8df08c75 NF: performPreview always return true 2020-11-19 02:22:25 +00:00
Arthur Milchior
83afaf6176 NF: executeTouchCommand always return false 2020-11-19 02:22:25 +00:00
Arthur Milchior
f016ec5eff NF: editCard always return true 2020-11-19 02:22:25 +00:00
Arthur Milchior
f979429386 NF: lookUp always return true, never read. Delete 2020-11-19 02:22:25 +00:00
oakkitten
88db890ecc remove background color for overflow menu target area
this does not remove background for the menu itself
2020-11-19 02:04:34 +00:00
AnkiDroid Translations
230e7b9def Updated strings from Crowdin 2020-11-18 13:46:53 -05:00
David Allison
04e941a2a2 hardFactor: limit to between 5% and 120%
Matches Anki Desktop:
98a4a1927a/qt/aqt/forms/dconf.ui (L374-L379)

Fixes 7713
2020-11-18 13:16:58 -05:00
Mike Hardy
7bba58f575 Bumped version to 2.15alpha5
@branch-specific
2020-11-17 19:20:02 +00:00
Mike Hardy
03d2b50db4
chore: bump ssh-agent dependency to handle github set-env deprecation 2020-11-17 14:12:52 -05:00
AnkiDroid Translations
f066140efa Updated strings from Crowdin 2020-11-17 14:06:52 -05:00
bguneys
ae67a65964 Remove unnecessary imports 2020-11-17 12:17:54 -05:00
bguneys
a2bce1135d Deck Picker: Convert the dialog to a Toast 2020-11-17 12:17:54 -05:00
bguneys
89ccb8e9b0 Deck Picker: Convert the dialog to a Toast 2020-11-17 12:17:54 -05:00
bguneys
ceb16ee176 Deck Picker: Convert the dialog to a Toast 2020-11-17 12:17:54 -05:00
David Allison
eb8edbbd91 NF: Explain duplicate string "Rename"
model_browser_rename

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
15fb50eebf NF: Remove duplicate string "Translate"
help_item_support_translate_ankidroid

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
e33adc9f44 NF: Disambiguate string: "add"
import_message_add
deck_conf_add
menu_add

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
81f7af5165 NF: Explain string case difference: Card Browser 2020-11-17 11:25:09 -05:00
David Allison
bff7c6a40b Remove Duplicate strings: undo constants
If we lowercase the values, we can remove a lot of duplicates

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
a31b034869 Remove Duplicate string: no
dialog_no made more sense as the rest of the dialog options had the prefix

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
2c9a477326 Remove Duplicate string: integrity_check_positive
Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
60e137493d Remove Duplicate string: menu_toggle_mic_tool_bar
None of the other menu strings were in Title Case

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
97d779b940 Fix card deleted message
The snackbar did not appear as the activity was closed.

Instead, a toast works
2020-11-17 11:17:43 -05:00
David Allison
f29886d6c5 Fix card generation failure message
The snackbar did not appear as the activity was closed.

Instead, a toast works
2020-11-17 11:17:43 -05:00
David Allison
76f779af10 Note Editor: Option to replace newline with HTML
This defaults to "on".

This is a persistent setting. I feel now is a good time to add this
as we both fix a long-standing issue, and we have the toolbar in the
note editor, which allows a user to manually insert <br/> quickly

Fixes: 3304
Related: 7124 (toolbar)
2020-11-17 11:15:05 -05:00
gradle-update-robot
47b6bbab6a Update Gradle Wrapper from 6.7 to 6.7.1.
Signed-off-by: gradle-update-robot <gradle-update-robot@regolo.cc>
2020-11-17 09:13:31 -05:00
sudomain
13434fb84d Change rename field string
It previously read "Rename note type" while renaming a field
2020-11-17 09:11:16 -05:00
David Allison
315187b9b1 TEST: Handle EMFILE (too many files)
`dir` can exist, but listFiles() can return null if there are too many
file descriptors open

Discovered during testing of Rust implementation
2020-11-17 09:09:58 -05:00
David Allison
ff27c1827c Playing Single sound: Handle File Not Found
Related: 7009
2020-11-17 09:07:05 -05:00
David Allison
61c7338176 NF: Rename method
For readability and accuracy

displayInefficientImageSnackbar -> displayMediaUpgradeRequiredSnackbar
2020-11-17 09:07:05 -05:00
David Allison
7e6bd884a4 Display content error on missing Sound
We need an activity reference to display a Snackbar - so pass in an error
handler to the Sound class

Related: 7009
2020-11-17 09:07:05 -05:00
Arthur Milchior
eb90b09cb3 NF: correct an indentation problem 2020-11-17 09:03:54 -05:00
Arthur Milchior
13eda5cd0b NF: Use sql to query distinct directly 2020-11-15 23:07:08 +00:00