lukstbit
390a7cd3ac
Remove unused calls to updateValuesForDeck()
...
The calls that were deleted weren't using the method's return type and
as the method just queries for state removing the calls should be safe.
2024-07-12 18:49:42 +00:00
leobugeja
d3c427b746
fix: card preview autoplay audio
2024-07-11 11:26:46 +00:00
Mike Hardy
869f8d8af3
Dependency updates 20240710 ( #16718 )
...
* build(deps): bump org.junit.jupiter:junit-jupiter from 5.10.2 to 5.10.3
Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5 ) from 5.10.2 to 5.10.3.
- [Release notes](https://github.com/junit-team/junit5/releases )
- [Commits](https://github.com/junit-team/junit5/compare/r5.10.2...r5.10.3 )
---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump org.junit.vintage:junit-vintage-engine
Bumps [org.junit.vintage:junit-vintage-engine](https://github.com/junit-team/junit5 ) from 5.10.2 to 5.10.3.
- [Release notes](https://github.com/junit-team/junit5/releases )
- [Commits](https://github.com/junit-team/junit5/compare/r5.10.2...r5.10.3 )
---
updated-dependencies:
- dependency-name: org.junit.vintage:junit-vintage-engine
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump org.junit.jupiter:junit-jupiter-params
Bumps [org.junit.jupiter:junit-jupiter-params](https://github.com/junit-team/junit5 ) from 5.10.2 to 5.10.3.
- [Release notes](https://github.com/junit-team/junit5/releases )
- [Commits](https://github.com/junit-team/junit5/compare/r5.10.2...r5.10.3 )
---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-params
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump org.robolectric:robolectric from 4.12.2 to 4.13 (#16703 )
Bumps [org.robolectric:robolectric](https://github.com/robolectric/robolectric ) from 4.12.2 to 4.13.
- [Release notes](https://github.com/robolectric/robolectric/releases )
- [Commits](https://github.com/robolectric/robolectric/compare/robolectric-4.12.2...robolectric-4.13 )
---
updated-dependencies:
- dependency-name: org.robolectric:robolectric
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump org.mockito.kotlin:mockito-kotlin from 5.3.1 to 5.4.0 (#16710 )
Bumps [org.mockito.kotlin:mockito-kotlin](https://github.com/mockito/mockito-kotlin ) from 5.3.1 to 5.4.0.
- [Release notes](https://github.com/mockito/mockito-kotlin/releases )
- [Commits](https://github.com/mockito/mockito-kotlin/compare/5.3.1...5.4.0 )
---
updated-dependencies:
- dependency-name: org.mockito.kotlin:mockito-kotlin
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump org.jsoup:jsoup from 1.17.2 to 1.18.1
Bumps [org.jsoup:jsoup](https://github.com/jhy/jsoup ) from 1.17.2 to 1.18.1.
- [Release notes](https://github.com/jhy/jsoup/releases )
- [Changelog](https://github.com/jhy/jsoup/blob/master/CHANGES.md )
- [Commits](https://github.com/jhy/jsoup/compare/jsoup-1.17.2...jsoup-1.18.1 )
---
updated-dependencies:
- dependency-name: org.jsoup:jsoup
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-10 21:49:06 -06:00
Mike Hardy
82dea2af95
feat: bump targetSdk to 34
2024-07-11 02:45:12 +00:00
David Allison
1de4391fdf
fix(broadcast-receivers): specify export behavior (API 34)
...
In API 34, `registerReceiver` needs to either accept
`RECEIVER_EXPORTED` or `RECEIVER_NOT_EXPORTED`,
otherwise an exception is thrown
So, introduce `Context.registerReceiverCompat` to avoid code
churn, and use it
Issue 16713
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported
2024-07-11 02:45:12 +00:00
AnkiDroid Translations
16de500e9a
Updated strings from Crowdin
2024-07-08 15:43:55 +00:00
SanjaySargam
f17e059498
simplify deckpicker with unified menu
2024-07-08 13:53:37 +00:00
SanjaySargam
50832f9816
hide fragment when collection is empty
2024-07-08 13:53:37 +00:00
AnkiDroid Translations
e6eaa5c22e
Updated strings from Crowdin
2024-07-08 13:30:57 +00:00
AnkiDroid Translations
1125658c23
Updated strings from Crowdin
2024-07-08 04:54:15 +00:00
Arthur Milchior
016330188f
Clarify note type ui model
...
I found the code slightly unclear and tried to improve it.
* NotetypeBasicUiModel was not related to basic note types
* isStandard and useCount did not seem to me to have a clear meaning in anki lexicon, so must be document
* toUiModel can't be appled to a standard entry as far as I understand it, and is in any case never applied to a standard note type currently, so we can remove the argument.
2024-07-08 03:25:56 +00:00
Arthur Milchior
34263d1c87
NF: delete tools/crashes-data-mining
...
This folder has not been updated once in 14 years, refers to a
data source that does not exists anymore, and would be used to provide
analytics we can probably get somewhere else.
I don't expect it's worth anyone time to try repairing it.
Closes #16695 . Also simplify sligthly bug #16692 .
2024-07-07 18:02:14 +00:00
Arthur Milchior
d71d315d4d
NF: add Sargam to usernames
...
This way it won't be shown as typo by Intelli-J
2024-07-07 16:57:58 +00:00
AnkiDroid Translations
5d3960521a
Updated strings from Crowdin
2024-07-05 14:29:30 +00:00
Ashish Yadav
74a02eec9a
enhancement: show discard change dialog
...
* fix: share the updated text to note editor
* fix: cloze number to increment only in increment mode
Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
2024-07-05 13:43:07 +00:00
AnkiDroid Translations
e47cc2fe7f
Updated strings from Crowdin
2024-07-04 17:53:18 +00:00
Voczi
f02c91c3f2
Update keeper plugin to 0.16.1
2024-06-29 16:36:32 +00:00
Brayan Oliveira
666c8ae135
feat(new reviewer): next times
2024-06-29 10:45:56 +00:00
Brayan Oliveira
0a90271cdb
refactor: add a @LibAnkiAlias
2024-06-29 10:45:56 +00:00
Mike Hardy
a9fd2c5cca
Bumped version to 2.19alpha8
2024-06-27 21:45:10 +00:00
Sachin Kumar Singh
1ad67a9ac9
No Flag Icon not showing on light theme, Fixed #16622
2024-06-27 20:29:10 +00:00
Mike Hardy
674d93b92a
Dependency updates 20240627 ( #16666 )
...
* build(deps): bump com.google.protobuf:protobuf-kotlin-lite
Bumps com.google.protobuf:protobuf-kotlin-lite from 4.27.1 to 4.27.2.
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump org.jetbrains.kotlinx:kotlinx-serialization-json
Bumps [org.jetbrains.kotlinx:kotlinx-serialization-json](https://github.com/Kotlin/kotlinx.serialization ) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/Kotlin/kotlinx.serialization/releases )
- [Changelog](https://github.com/Kotlin/kotlinx.serialization/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Kotlin/kotlinx.serialization/compare/v1.7.0...v1.7.1 )
---
updated-dependencies:
- dependency-name: org.jetbrains.kotlinx:kotlinx-serialization-json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidx.test:runner from 1.5.2 to 1.6.0
Bumps androidx.test:runner from 1.5.2 to 1.6.0.
---
updated-dependencies:
- dependency-name: androidx.test:runner
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump com.github.triplet.play from 3.10.0 to 3.10.1
Bumps com.github.triplet.play from 3.10.0 to 3.10.1.
---
updated-dependencies:
- dependency-name: com.github.triplet.play
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidx.test:runner from 1.6.0 to 1.6.1
Bumps androidx.test:runner from 1.6.0 to 1.6.1.
---
updated-dependencies:
- dependency-name: androidx.test:runner
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidx.test.ext:junit from 1.1.5 to 1.2.1
Bumps androidx.test.ext:junit from 1.1.5 to 1.2.1.
---
updated-dependencies:
- dependency-name: androidx.test.ext:junit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidxTextCore from 1.5.0 to 1.6.1
Bumps `androidxTextCore` from 1.5.0 to 1.6.1.
Updates `androidx.test:rules` from 1.5.0 to 1.6.1
Updates `androidx.test:core` from 1.5.0 to 1.6.1
---
updated-dependencies:
- dependency-name: androidx.test:rules
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: androidx.test:core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidxFragmentKtx from 1.8.0 to 1.8.1
Bumps `androidxFragmentKtx` from 1.8.0 to 1.8.1.
Updates `androidx.fragment:fragment-ktx` from 1.8.0 to 1.8.1
Updates `androidx.fragment:fragment-testing` from 1.8.0 to 1.8.1
Updates `androidx.fragment:fragment-testing-manifest` from 1.8.0 to 1.8.1
---
updated-dependencies:
- dependency-name: androidx.fragment:fragment-ktx
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: androidx.fragment:fragment-testing
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: androidx.fragment:fragment-testing-manifest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump espresso from 3.5.1 to 3.6.1
Bumps `espresso` from 3.5.1 to 3.6.1.
Updates `androidx.test.espresso:espresso-contrib` from 3.5.1 to 3.6.1
Updates `androidx.test.espresso:espresso-core` from 3.5.1 to 3.6.1
---
updated-dependencies:
- dependency-name: androidx.test.espresso:espresso-contrib
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: androidx.test.espresso:espresso-core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-27 15:29:32 -05:00
lukstbit
d8831cf24a
Fix adding a notetype when using the name of a standard notetype
...
This fixes a bug where the user couldn't add a notetype with the name
of one of the standard notetypes(even if it didn't existed), because
the code checked the new name against the existing notetypes names +
the standard notetypes names so it behaved like the name already
existed.
The change makes the code look only at the existing notetypes names.
2024-06-27 18:57:34 +00:00
AnkiDroid Translations
969c0e8f05
Updated strings from Crowdin
2024-06-27 18:52:36 +00:00
Brayan Oliveira
d20d8c3e42
feat(new reviewer): auto advance
...
This differs from the legacy reviewer in four things:
1. It implements `Show reminder` as an action (it is a tooltip in Anki, so I made it a snackbar here)
2. It doesn't follow the global switch in settings, as Anki desktop doesn't have one and users complained about finding the global setting unexpected
3. There is now a `Question action` setting
4. The legacy reviewer has an issue where the same configuration is carried through all cards in the review session. So if a card with a different deck config shows up, the config won't be respected. This is fixed in the new reviewer
2024-06-27 18:52:05 +00:00
Voczi
edd15ee8f8
Add support for custom certificate
...
(9e3a34f17f
)
2024-06-27 17:55:17 +00:00
AnkiDroid Translations
b064f4965f
Updated strings from Crowdin
2024-06-27 17:44:18 +00:00
David Allison
79b7a6e8bd
tests: reduce log spam in ChangeManager
...
No point in logging a no-op in `@Before`
removes log: `D/ChangeManager: clearing 0 subscribers`
2024-06-27 16:56:38 +00:00
David Allison
d8633961b8
fix(tests): allow update to espresso 3.6.1
...
`ViewActions.closeSoftKeyboard` became `@CheckResult`
`androidx.test.espresso.Espresso.closeSoftKeyboard` is not
PR 16657
2024-06-27 16:50:52 +00:00
Voczi
a4f0d8f511
Implement release mode instrumentation with better proguard rules
2024-06-26 15:58:07 +00:00
Mike Hardy
9951decf36
test: bump jacoco to 0.8.12
2024-06-26 15:58:07 +00:00
Mike Hardy
584d5bb803
test(ci): do not pre-compress emulator logcat pre-upload
...
upload-artifact already compresses on upload, so this was an
ineffective double-compression from a space perspective, and worse
when you downloaded it you had to double-uncompress
2024-06-26 15:58:07 +00:00
Mike Hardy
9480c1f2b5
test(ci): remove "clearCaches" workflow feature
...
in practice it is currently unused
it was added originally because github offered no way to delete caches
cache management (including delete) is possible using github web ui now though,
and it is all I've used for months
2024-06-26 15:58:07 +00:00
Mike Hardy
4aecb2a246
Bumped version to 2.19alpha7
2024-06-25 12:09:20 +00:00
Voczi
bef936d118
Fix publish workflow after recent changes
2024-06-25 07:08:15 -05:00
Mike Hardy
b6c1fd314e
test: fixup warning message when no coverage of type is found
...
doesn't look like string format works in logger.warn, use concat
2024-06-24 17:34:10 +00:00
Mike Hardy
b15994cad0
test: ensure non-zero coverage for androidTest reports
...
there are many toolchain incompatibilities which can result in a
false-positive androidTest test run, but with zero actual coverage
tallied
this adds a finalization task that scans the coverage report looking
for an aggregate coverage count that is non-zero
2024-06-24 12:35:54 +00:00
Mike Hardy
850c391d43
test: copy testlib common files into androidTest directly
...
we are unable to depend on them in androidTestImplementation terms
because android gradle plugin has a bug that breaks coverage with
a shared test/androidTest dep
we want the code to be truly shared though and just need to work around
the issue temporarily (we hope)
so a build-time copy seems the least-worst alternative
2024-06-24 12:35:54 +00:00
Mike Hardy
cf1b98d0a2
refactor(test): shift common testlib items into a 'common' package
...
this means they have their own separate directory with no collisions
in other modules that consume them
2024-06-24 12:35:54 +00:00
Voczi
1456d77dc3
Switch from hardcoded signing config
2024-06-24 12:28:04 +00:00
David Allison
07c4923407
improvement: re-add import qualifier
...
Removed in
301f0a152a
But 'Builder' is ambiguous
2024-06-23 15:01:13 +00:00
ShalenMathew
301f0a152a
Fix IDE Warning: Removing redundant qualifiers name ( #16638 )
2024-06-23 10:19:00 -03:00
Brayan Oliveira
8b196f6f68
feat(new reviewer): counts
2024-06-22 09:00:17 -03:00
snowtimeglass
16c23cf167
Rename "Cancel" of Media Sync to "Abort"
...
- in "Media Sync Log" dialog box and in "Syncing media" notification
- The use of "Abort" in the dialog box is consistency with Anki Desktop.
2024-06-21 19:08:31 +00:00
Brayan Oliveira
a4f9f95ad2
refactor: handleNoteEditorResult and handleDeckOptionsResult
2024-06-21 17:35:10 +00:00
Brayan Oliveira
8ab378ca80
feat(new reviewer): flags
2024-06-21 17:35:10 +00:00
Brayan Oliveira
90a3a419a3
refactor: define flags ids statically
...
It is technically possible (although unlikely) to get an ID conflicts when using the ordinals as IDs.
Also, I think that `onMenuItemClick` is easier to follow this way.
2024-06-21 17:35:10 +00:00
Brayan Oliveira
700ee53e17
feat(new reviewer): undo and redo
2024-06-21 17:35:10 +00:00
Brayan Oliveira
e5a9652def
feat(new reviewer): user action
2024-06-21 17:35:10 +00:00
Brayan Oliveira
6fc9a15a0b
feat(new reviewer): suspend
2024-06-21 17:35:10 +00:00