The template editor edits the model template live in the database
which bleeds into Note.model, if you discard the template edits and
return to the NoteEditor the Note.model.templates state was still the
edited + reverted state. This hook and call allow for the Note.model
object to be loaded from the database where the template editor left
the correct state as it was closing down
The multimedia field editor is set up as a text editor to start, but if you
use it to start an Activity that fetches audio for a translation, it needs
to re-draw the options menu with an audio config when the activity result
returns, otherwise there are state issues with media recorder
- Previously Preview was always available, fixes#4987 crash when no cards
- Previously if you went to another Activity with an active search, it was forgotten
This starts the process of exercising HTTP features
prior to any contemplated move to OkHttp. More
importantly it makes sure basic HTTP works to guard against
things like issue #5000
I looked in the source anki source code, and they perform no
sanity checking on authentication (the referenced issue) so I
see no need to wait another 3 years to do it here...the referenced
issue is not available any long either, so I think deleting the
comment is appropriate
Travis is flaky at best on emulators, and adding UI tests with
all of their inherent timing issues to Travis would make it
unreliable. These @LargeTest ones work well locally though
This may not be related to 27.0.2->27.1.1 support lib lifecycle changes,
and it may be present in other objects or have a better solution but this
fixes crash on opening CardBrowser with an empty collection
Previously I've been relying on a personal collection of
crash bugs to test the crash dialog, but that's a poor testing
experience - now we have an advanced preference area to just crash
During the ACRA upgrade some branding was already broken, and
the rest was lost, when I finally saw the dialog again with
fresh eyes it was terrible so this puts the icon and title back
Calling code handles null return values already and silently moves on,
and called library method will immediately throw NPE if the requested
entry name doesn't exist, so any media database / file de-synchronization
blocks us from importing otherwise. This allows us to successfully import
exports that have media db / file discrepancies
The DeckPicker options menu wasn't being initialized correctly
during the first run of the application after install when all
the dialogs popped up.
The correct thing to do is invalidate it, the system will re-init
https://stackoverflow.com/a/41631514/9910298
The new behavior of CollectionLoader is to immediately call onCollectionLoaded() if the collection is already open,
so the function must be called after all the initialization is complete, Also we need to call the super function
in order for the progress bar to be cleared.
We used to call finish() here but that no longer works on newer versions of Android, as we get kicked back to the DeckPicker.
It seems the following change to PreferenceActivity addresses our use case for newer versions of Android:
6af15ebcfe%5E%21/core/java/android/preference/PreferenceActivity.java
So I've ported that over so that we get the correct behavior on all versions of Android
These are primarily to help first-time reporters/contributors, and I find they get in the way when I'm creating issues/prs
Moving to the bottom seems like a reasonable compromise to me
