0
0
mirror of https://github.com/ankidroid/Anki-Android.git synced 2024-09-20 20:03:05 +02:00
Commit Graph

11810 Commits

Author SHA1 Message Date
David Allison
eb8edbbd91 NF: Explain duplicate string "Rename"
model_browser_rename

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
15fb50eebf NF: Remove duplicate string "Translate"
help_item_support_translate_ankidroid

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
e33adc9f44 NF: Disambiguate string: "add"
import_message_add
deck_conf_add
menu_add

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
81f7af5165 NF: Explain string case difference: Card Browser 2020-11-17 11:25:09 -05:00
David Allison
bff7c6a40b Remove Duplicate strings: undo constants
If we lowercase the values, we can remove a lot of duplicates

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
a31b034869 Remove Duplicate string: no
dialog_no made more sense as the rest of the dialog options had the prefix

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
2c9a477326 Remove Duplicate string: integrity_check_positive
Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
60e137493d Remove Duplicate string: menu_toggle_mic_tool_bar
None of the other menu strings were in Title Case

Related: 7582
2020-11-17 11:25:09 -05:00
David Allison
97d779b940 Fix card deleted message
The snackbar did not appear as the activity was closed.

Instead, a toast works
2020-11-17 11:17:43 -05:00
David Allison
f29886d6c5 Fix card generation failure message
The snackbar did not appear as the activity was closed.

Instead, a toast works
2020-11-17 11:17:43 -05:00
David Allison
76f779af10 Note Editor: Option to replace newline with HTML
This defaults to "on".

This is a persistent setting. I feel now is a good time to add this
as we both fix a long-standing issue, and we have the toolbar in the
note editor, which allows a user to manually insert <br/> quickly

Fixes: 3304
Related: 7124 (toolbar)
2020-11-17 11:15:05 -05:00
gradle-update-robot
47b6bbab6a Update Gradle Wrapper from 6.7 to 6.7.1.
Signed-off-by: gradle-update-robot <gradle-update-robot@regolo.cc>
2020-11-17 09:13:31 -05:00
sudomain
13434fb84d Change rename field string
It previously read "Rename note type" while renaming a field
2020-11-17 09:11:16 -05:00
David Allison
315187b9b1 TEST: Handle EMFILE (too many files)
`dir` can exist, but listFiles() can return null if there are too many
file descriptors open

Discovered during testing of Rust implementation
2020-11-17 09:09:58 -05:00
David Allison
ff27c1827c Playing Single sound: Handle File Not Found
Related: 7009
2020-11-17 09:07:05 -05:00
David Allison
61c7338176 NF: Rename method
For readability and accuracy

displayInefficientImageSnackbar -> displayMediaUpgradeRequiredSnackbar
2020-11-17 09:07:05 -05:00
David Allison
7e6bd884a4 Display content error on missing Sound
We need an activity reference to display a Snackbar - so pass in an error
handler to the Sound class

Related: 7009
2020-11-17 09:07:05 -05:00
Arthur Milchior
eb90b09cb3 NF: correct an indentation problem 2020-11-17 09:03:54 -05:00
Arthur Milchior
13eda5cd0b NF: Use sql to query distinct directly 2020-11-15 23:07:08 +00:00
Arthur Milchior
5378e0626b NF: always int 2020-11-15 20:35:00 +00:00
David Allison
ebba0a01b1 BugFix: Undo - Ensure data in grid is updated
Cause: 23f9d804f2 (7535)

Double searches were cancelled

Fixes 7674
2020-11-15 07:36:02 -05:00
David Allison
43b06bc785 Show undo menu on reset, reposition and resched
Tests are sadly wonky under Robolectric

Fixes 7674
2020-11-15 07:36:02 -05:00
David Allison
0389d60b51 Refresh Card Browser data on reposition
Data was stale

Reposition, reset and reschedule

Fixes 7674
2020-11-15 07:36:02 -05:00
David Allison
057be86c6b NF: checkCardsAtPositions - accept varargs
Slightly cleans up the code
2020-11-15 07:36:02 -05:00
David Allison
c153719c40 NF: Extract resetProgressNoConfirm
useful for testing
2020-11-15 07:36:02 -05:00
David Allison
e5cdc91a9b NF: Extract onResetProgress
useful for testing
2020-11-15 07:36:02 -05:00
David Allison
9775707316 NF: Extract rescheduleWithoutValidation
useful for testing
2020-11-15 07:36:02 -05:00
David Allison
78beef4bc7 NF: extract repositionCardsNoValidation
Useful for testing
2020-11-15 07:36:02 -05:00
David Allison
383aa2493e NF: Rename checkedCardsAtPositions
checkCardsAtPositions makes more sense as we perform the "check" action
2020-11-15 07:36:02 -05:00
Mike Hardy
f933e372f4 Bumped version to 2.15alpha4
@branch-specific
2020-11-14 14:45:51 +00:00
AnkiDroid Translations
b0bdb47cd9 Updated strings from Crowdin 2020-11-14 09:38:45 -05:00
Arthur Milchior
4cbe8f4881 NF: replace a line by its def 2020-11-14 08:35:32 -05:00
David Allison
3dd23578b5 Revert: "NF: save current search to avoid doing it twice"
Reverts 23f9d804f2

Actions such as adding a new card no longer update the view

Fixes 7676
2020-11-14 08:32:02 -05:00
David Allison
3a8e43af0f Remove unused class: CardStats
Remove: card_details_question
Remove: card_details_answer

card_details_due is still used
2020-11-14 08:28:22 -05:00
David Allison
b13b7fa869 NF: Remove Specific Error String
Removed: card_info_cannot_load

The user knows they're opening the info screen - so we can show a generic error
2020-11-14 08:26:46 -05:00
Mike Hardy
7c9ce59bfa
CI: remove workspace usage, introduction coincident with CI flakiness 2020-11-14 08:20:55 -05:00
Mike Hardy
b68b541920
CI: remove Gradle caching from Travis, it appears problematic 2020-11-14 08:20:55 -05:00
David Allison
67cf0aca22 Remove MIUI Keyboard Hack Preference
No longer necessary now we have the note editor toolbar.

Related: 43151b6187
Fixed By: 7124
2020-11-14 08:07:48 -05:00
David Allison
4f15fe582a NF: Improve widget in designer
Add a few tools: attributes to make it look sensible on a 1x1 grid
2020-11-13 09:30:58 -05:00
David Allison
eb84e4ed4b NF: Remove Specific Error String
Removed: card_browser_note_editor_error

The user knows they're opening the editor - so we can show a generic error
2020-11-13 09:17:40 -05:00
David Allison
922b2e6803 Strings: Remove specific error message
No point in translating: what the user was doing adds no value to the message
2020-11-13 09:17:40 -05:00
David Allison
41b40bcea2 NF: Mark string for no screenshot 2020-11-13 09:17:40 -05:00
David Allison
2352ef013c Disallow adding 0 byte files to Media
This causes sync errors - these are handled and shown to the user:
2e3d1168a8

But better to stop them at the source to reduce errors in ACRA
and improve UX.

Fixes 7662
2020-11-13 09:14:41 -05:00
David Allison
d1c0906cd3 Warn on Protocol-relative URLs
We add a snackbar to warn the user and explain how to fix this.

In Anki, protocol-relative URLS are converted to https://
In AnkIDroid, they're converted to file://

file:// fails to load the image - we can't redirect from shouldInterceptRequest
Loading synchronously is not viable, so all we can do is use a snackbar.

Fixes 6102
2020-11-13 09:05:27 -05:00
Mike Hardy
2c79e41214 Bumped version to 2.15alpha3
@branch-specific
2020-11-13 02:25:14 +00:00
AnkiDroid Translations
d0ba40084b Updated strings from Crowdin 2020-11-12 20:59:15 -05:00
David Allison
218bb06248 NF: Improve string: locale_selection_dialog_title
Keyboard Hint Selection -> Keyboard Language Selection

"Hint" was a fairly meaningless word
2020-11-12 20:41:36 -05:00
David Allison
94244ce015 Note Editor Toolbar: Insert "<hr>" before cursor
From beta feedback: this wasn't a great experience.
2020-11-12 07:51:18 -05:00
David Allison
aff3b7ca8e BugFix: Handle null inputConnection
Fixes 7658
2020-11-12 07:45:55 -05:00
David Allison
3537cdf98e Fix flaky test: limitAppliedAfterReview
Fixes 7565
2020-11-11 20:39:08 -05:00