mirror of
https://github.com/mpv-player/mpv.git
synced 2024-09-20 20:03:10 +02:00
a908101258
Using e.g. --vf=format=0bgr showed obviously wrong colors with --vo=gpu. The reason is that leading padding wasn't handled correctly. Try to hack fix it. While the code in copy_image() is somewhat reasonable, I can't tell what the fuck is going on with that HOOKED shit. For some reason this HOOKED shit doesn't use copy_image() (???), or uses it incorrectly. It affects debanding. --deband=no works correctly. If it's enabled, the crap in hook_prelude() is needed. I bet there are many more bugs with this. For example, the deband shader will try to deband the alpha channel if the format abgr is used (because the correct component order is only established later). This can be tested by inserting a "color.x = 0;" at the end of the deband shader, and using --vf=format=rgba vs. abgr. I cannot comprehend why it doesn't just store explicitly which components a texture contains, and why it doesn't just read the components always in an uniform way. There's a big chance this fix works only by coincidence. This shouldn't have been so hard either. Time for a complete rewrite? |
||
|---|---|---|
| .. | ||
| context.c | ||
| context.h | ||
| d3d11_helpers.c | ||
| d3d11_helpers.h | ||
| error_diffusion.c | ||
| error_diffusion.h | ||
| hwdec.c | ||
| hwdec.h | ||
| lcms.c | ||
| lcms.h | ||
| libmpv_gpu.c | ||
| libmpv_gpu.h | ||
| osd.c | ||
| osd.h | ||
| ra.c | ||
| ra.h | ||
| shader_cache.c | ||
| shader_cache.h | ||
| spirv_shaderc.c | ||
| spirv.c | ||
| spirv.h | ||
| user_shaders.c | ||
| user_shaders.h | ||
| utils.c | ||
| utils.h | ||
| video_shaders.c | ||
| video_shaders.h | ||
| video.c | ||
| video.h | ||