changed id to just be string. #2

Merged

thetek merged 2 commits from Id-string-fix into main 2024-04-09 19:00:55 +02:00

Conversation 0 Commits 2 Files Changed 1 +1 -1

jeffrey_van commented 2024-04-05 07:11:51 +02:00

Member

Copy Link

Did small fix that Jagjit said to change the id to be of string format. Not sure if we wanted to add any constraints but uhhh yeah.

Did small fix that Jagjit said to change the id to be of string format. Not sure if we wanted to add any constraints but uhhh yeah.

jeffrey_van added 1 commit 2024-04-05 07:11:52 +02:00

changed id to just be string. bde578d43f

thetek was assigned by jeffrey_van 2024-04-05 07:12:02 +02:00

thetek approved these changes 2024-04-05 08:12:21 +02:00

Dismissed

thetek left a comment

Owner

Copy Link

We should also verify that the id is a uuid. This can be done with string & tags.Format<"uuid">.

We should also verify that the id is a uuid. This can be done with `string & tags.Format<"uuid">`.

thetek requested changes 2024-04-05 08:13:38 +02:00

Dismissed

thetek left a comment

Owner

Copy Link

Also, we need to reflect this change in world-sim/misc/schema-validator

Also, we need to reflect this change in world-sim/misc/schema-validator

jeffrey_van added 1 commit 2024-04-09 18:57:37 +02:00

fixed 403d8ece16

thetek approved these changes 2024-04-09 19:00:40 +02:00

thetek merged commit 403d8ece16 into main 2024-04-09 19:00:55 +02:00

thetek deleted branch Id-string-fix 2024-04-09 19:00:55 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

thetek

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

thetek

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: thi-sjsu-project/message-schemas#2

No description provided.