Simply for the sake of consistency. It will ensure that when searching for a
method, function or variable name, I have a single word to look for
This was done by a simple search and replace in .java and .kt files, preserving
case.
The only exception being org.junit.rules.TemporaryFolder and its method
`newFolder`, which obviously was not renamed.
Note that `folder` can't be entirely renamed to `directory` either because of
the class `DirectoryStream`. It seems even Java is not consistent between Folder
and directory
- In DeckPickerNoSpaceToDowngradeDialogRemoving: removing collection's nullability was a minimal necessary change in order achieve compilation.
- In BackupManagerTest: replaced empty string by collection's default path to avoid test failure caused by NPEs. The affected method should have not be called with an empty string describing the path beforehand.
If DeleteEmptyDirectory fails, we want to perform
the MoveDirectory that spawned it
This could happen for many reasons, such as a failed file
move, or adding a file to `AnkiDroid` during the process
A future commit will want to handle accessing the queue
while the executor is executing. executeAll() did not allow this
So provide an executor which has the list of operations public
The general design is TBC, but the functionality will be used in prod
Normally, this commit tests every cases which indirectly access the list of files of a
folder and which . I.e.
* Directory's hasFile
* MoveDirectoryContent.createInstance
* DeleteDirectory.execute
* MoveDirectory executeAll
This option is useful to anyone who wants to know "how many cards did I
study today (in total), and how many cards are due tomorrow (in total)".
In this situation it can save a few clicks and scrolls which can be slow
on e-ink displays.
Some additional context:
If using a single "To Review" filtered deck then stats are pretty
meaningless. For instance "Studied 3 cards in 0 minutes today". To
find the real statistics after studying with a filtered deck I have
to select "All decks" and then I correctly see "Studied 491 cards in
25 minutes today".
* 'protected' visibility is effectively 'private' in a final class
* Variable is same as 'X' and can be inlined
* Cascade if should be replaced with when
* Fix variable names
* Always returns null type
