SingleFragmentActivity was built with a call to setTransparentStatusBar()
which worked great for the initial Statistics page but currently the
activity can be used/is used with other fragments as well which don't
need this call(and results in undesired status bar foreground colors).
It seems it will never get used.
19-onboarding was not sent to crowdin for translation. So no need to
remove the file in other directories or update the translation script.
I was very surprised to see we used dynamic and not static one. I
tried to transform them into static shortcut, which seems cleaner. And
realized that we can't for a very absurd technical reason.
So I document it here, hoping nobody else will lose time on it.
I discover that each time an action occur in the reviewer, the deck
picker is updated. This is uselessly costly.
I tested and when going back to the deck picker, I still get the up to
date data immediately.
* We previously removed the camera permission from the manifest file (commit: fix: remove camera permission #14162, by Brayan). However, the code now includes a check for this permission that was introduced in commit 6a8ede0. Since th permission is not declared, this check fails, and the camera cannot be launched.
* The camera feature is declared in the manifest file as <uses-feature android:name="android.hardware.camera" /> rather than using <uses-permission android:name="android.permission.CAMERA" />. This omission causes the current permission
check to always return false, preventing users from accessing the camera options. This PR corrects that issue by removing that permission check.
I dislike seeing this build-time deprecation warning every build,
and investigated if we could remove this. We can't but I was able
to see when, so I wrote it out in order to not forget and spend
the time researching again
The comment I left should show up in standard searches for removable
code based on VERSION_CODES / minSdk when we bump versions
the template previewer was tightly coupled with the template editor, and
that isn't a good design. To solve that, I decoupled the template
previewer in two fragments: a view and a standalone page.
All of the original style of the template previewer was fixed.
I gave credits to BrayanDSO in TemplatePreviewerPage.kt because most of
the code is his and I don't want the credits myself
I also removed the duplicated TabLayout in the card editor because it
didn't make sense to me.
this test is marked flaky so it won't ever run in CI but it was
failing locally for me every time as it was comparing the first
char of the string it pulled to a string, instead of string vs string
* added the alertDialog when users deletes the card type that causes orphan note which describes why the card type cannot be deleted also added the messages into the strings.xml
* completing changes requested for the fix-16789
* made changes in the test file to match the text in the fix:16789
* removed the unused string after adding the new string to test case.
Keyboard shortcuts:
Ctrl+Shift+A : Add tag
Ctrl+Shift+E : Export selected cards
Ctrl+Alt+N : Reset card progress
Ctrl+Alt+T : Toggle cards/notes
T : Show filter by tags
Ctrl+Shift+S : Reposition selected cards
Ctrl+Alt+S : Show saved searches
Ctrl+S : Save search
Alt+S : Show suspended cards
Ctrl+Shift+J : Toggle bury cards
Ctrl+J : Toggle suspended cards
Ctrl+Shift+I : Card Info
Ctrl+O : Show order dialog
Ctrl+M : Mark note
Ctrl+Z : Undo
ESC : Select none
Ctrl+1 : Red flag
Ctrl+2 : Orange flag
Ctrl+3 : Green flag
Ctrl+4 : Blue flag
Ctrl+5 : Pink flag
Ctrl+6 : Turqoise flag
Ctrl+7 : Purple flag
it is relatively easy to do an rm-rf directly but there are maintained
workflow actions that remove everything for you
This is the most-maintained fork of the most popular one I've used before
It defaults to true, and each item you remove takes time. I think dotnet
is the biggest one and should be sufficient so only remove it and that
should be sufficient
