* Bump com.squareup.leakcanary:leakcanary-android from 2.11 to 2.12
Bumps [com.squareup.leakcanary:leakcanary-android](https://github.com/square/leakcanary) from 2.11 to 2.12.
- [Release notes](https://github.com/square/leakcanary/releases)
- [Changelog](https://github.com/square/leakcanary/blob/main/docs/changelog.md)
- [Commits](https://github.com/square/leakcanary/compare/v2.11...v2.12)
---
updated-dependencies:
- dependency-name: com.squareup.leakcanary:leakcanary-android
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Bump org.jetbrains.kotlinx:kotlinx-coroutines-test from 1.7.1 to 1.7.2
Bumps [org.jetbrains.kotlinx:kotlinx-coroutines-test](https://github.com/Kotlin/kotlinx.coroutines) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases)
- [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md)
- [Commits](https://github.com/Kotlin/kotlinx.coroutines/compare/1.7.1...1.7.2)
---
updated-dependencies:
- dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-test
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Bump com.github.triplet.play from 3.8.3 to 3.8.4
Bumps com.github.triplet.play from 3.8.3 to 3.8.4.
---
updated-dependencies:
- dependency-name: com.github.triplet.play
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Bump com.android.tools.build:gradle from 7.4.2 to 8.0.2 (#13912)
* Bump com.android.tools.build:gradle from 7.4.2 to 8.0.2
Bumps com.android.tools.build:gradle from 7.4.2 to 8.0.2.
---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): forward-port BuildConfig / aidl / default-component to gradle 8
* convert to non-transitive R.attr style
- directly address the attributes via their specific names
- remove an R-containing IntDef since R is no longer constant
(the whole UndoAction class will disappear with new backend anyway)
* Use attrs directly from `android`
Practically, it is a non-functional change, but is is best and more natural to use attrs directly from android instead of using `com.google.android.material` as a intermediate
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: Brayan Oliveira <69634269+brayandso@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brayan Oliveira <69634269+brayandso@users.noreply.github.com>
* Bump org.jlleitschuh.gradle:ktlint-gradle from 11.4.1 to 11.4.2
Bumps org.jlleitschuh.gradle:ktlint-gradle from 11.4.1 to 11.4.2.
---
updated-dependencies:
- dependency-name: org.jlleitschuh.gradle:ktlint-gradle
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): require JDK17 for the build, use JDK17 in workflows
17+ is a requirement for new AndroidX library versions, fragment library
lint rules in particular are already failing our lint workflow because
they no longer operate on JDK11
* Bump lint_version from 30.4.2 to 31.0.2
Bumps `lint_version` from 30.4.2 to 31.0.2.
Updates `com.android.tools.lint:lint-api` from 30.4.2 to 31.0.2
Updates `com.android.tools.lint:lint` from 30.4.2 to 31.0.2
Updates `com.android.tools.lint:lint-tests` from 30.4.2 to 31.0.2
---
updated-dependencies:
- dependency-name: com.android.tools.lint:lint-api
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: com.android.tools.lint:lint
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: com.android.tools.lint:lint-tests
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* build: bump JDK source/target compat to JDK11
This is needed for new versions of deps, it passes
jacocoAndroidTestReport target against an API21 emulator (current
minSdkVersion) so seems to be compatible with all required things
* Bump org.mockito.kotlin:mockito-kotlin from 4.1.0 to 5.0.0
Bumps [org.mockito.kotlin:mockito-kotlin](https://github.com/mockito/mockito-kotlin) from 4.1.0 to 5.0.0.
- [Release notes](https://github.com/mockito/mockito-kotlin/releases)
- [Commits](https://github.com/mockito/mockito-kotlin/compare/4.1.0...5.0.0)
---
updated-dependencies:
- dependency-name: org.mockito.kotlin:mockito-kotlin
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): have gradle wrapper update PRs go into dependencies
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Changing colorControlActivated value originally had the purpose of tinting the preferences switches
Since this caused the problem of the text selector handle being the same color of the app bar on the light theme, using a more specific color selector should be preferred.
Android's color for the text handle is `colorControlActivated`, which defaults to `colorAccent` if not specified.
So, there are two ways to fix the issue:
1. Changing the handle style completely
2. Changing the switch/other widget colors
In order to keep the handle with a familiar look and compatible with Android future changes, and to make things simpler, it's better to avoid changing the handle, so this changes the switch color manually
To use the same color between the switch and other widgets (e.g. in SliderPreference), a `widgetColorActivated` attr similar to `colorControlActivated` was created
As per the documentation,
> By default, all drawables instances loaded from the same resource
share a common state; if you modify the state of one instance, all the
other instances will receive the same modification.
In reviewer, tint is applied to the icons of overflow menu items.
Previously, the icons were not mutated, which lead to these icons
appearing dark when used in other activities.
* Added marketing images for play store
* Update play store marketing images
* Update playstore images to reflect v2.16
* Fix title bar for play store marketing image 3
On (the back side of) card templates in the current backend,
if you input an incorrect closing tag, for example, "{{#Tags}}blah{{/Ta}}",
Its preview says "Found '{/Tags}}', but expected '{{/Ta}}' ".
This commit will fix the inappropriate reversal.
In other words, the preview will say "Found '{/Ta}}', but expected '{{/Tags}}' "
as on the desktop version and in the advanced "new backend".
`Locale.getDefault()` returns the app current language, so `getSystemLocale()` is used instead
Note that probably because of a platform bug, `getSystemLocale()` returns the app language as well on API 33, which *may* be fixed later because we are using an AppCompat alpha version
It probably should not be `NF`, but here it is. Because each time that
`setTitle` is called, `updateActionBar` is called immediately after and change
the title anyway.
In practice `setTitle` was setting a wrong title in the Reviewer, as it was
using current deck instead of the name of the current card.
Worse, while moving access to `col` to coroutine, I realized that this created
a race condition, where the title changed. That was catched by automated test,
so that's great actually.
We can also decide that actually, we wanted to keep `Preview` as title all the
time, and current behavior is a bug. In which case I suggest we move
`updateActionBar` to `Reviewer` and ensure it does not deal with title anymore.
* Fix: #12451 Issue: Replace string with plurals
String key pairs have been changed by adding '_new" to the key. Ex. name = "string_key" to name = "string_key_new"
Final Updates for Plural Candidates
* disambiguate apostrophe with expansion of text
---------
Co-authored-by: Mike Hardy <github@mikehardy.net>
persistent=false was added to `day_offset_preference` because the value is saved on the collection, which means that it doesn't need to be saved on SharedPreferences
