* add tts tag test
Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
* fix tts tag in browser
---------
Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
` if (isRecording || isRecordingPaused) {` returned true
so `clearRecording` was called even though `stop()` has been called
which crashed.
```
Done -> stopAndSaveRecording()
then -> done() -> onViewFocusChanged()
```
We fix this by setting the state to CLEARED after stopAndSaveRecording
Cause: cad603ef08
I missed that `stopAndSaveRecording` was public
Fixes 16321
Our longest unit test runner is Windows (~18 mins)
We are currently having timeout issues with this runner,
hitting this 40 min timeout.
This saves about 7x10 minutes of CI time per day for failed runners
Save the trees
* Created test for onSelectedTags.
* Reverted change, and moved to ReviewerTest.kt and formated it for it.
* Added test for onSelectedTags
* Modified to match legacy methods.
* assert question/answer display state before executing code under test
---------
Co-authored-by: Mike Hardy <github@mikehardy.net>
* fix: localizations not being added to values-iw
Some devices rely on hebrew translations being in the values-heb resource directory
and others rely on the translations being in values-iw. This change is a quick fix
which reuses the same algorithm for updating localization resources, while duplicating
hebrew translations to values-heb and values-iw.
* Update tools/localization/src/update.ts
---------
Co-authored-by: Mike Hardy <github@mikehardy.net>
The fix introduces a call to withCol {} to make sure the collection is
open and available before any of the code that updates the UI in
DeckPicker runs.
* build(deps): bump androidx.core:core-ktx from 1.12.0 to 1.13.0 (#16202)
* Reapply "Dependency updates 20240417 (#16193)"
This reverts commit a75ef34cf9.
* build(deps): bump androidx.core:core-ktx from 1.12.0 to 1.13.0
Bumps androidx.core:core-ktx from 1.12.0 to 1.13.0.
---
updated-dependencies:
- dependency-name: androidx.core:core-ktx
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* refactor: use same named parameter name as overridden method
else we get build warnings which we consider errors
* refactor: call View.generateViewId directly to handle deprecation
* refactor: handle CancellationSignal type ambiguity from deprecation by pinning w/declaration
attempting to cast it inline with `as CancellationSignal` results in "cast never succeeds"
warnings which are unsightly
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump com.squareup.leakcanary:leakcanary-android
Bumps [com.squareup.leakcanary:leakcanary-android](https://github.com/square/leakcanary) from 2.13 to 2.14.
- [Release notes](https://github.com/square/leakcanary/releases)
- [Changelog](https://github.com/square/leakcanary/blob/main/docs/changelog.md)
- [Commits](https://github.com/square/leakcanary/compare/v2.13...v2.14)
---
updated-dependencies:
- dependency-name: com.squareup.leakcanary:leakcanary-android
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump lint from 31.3.2 to 31.4.0
Bumps `lint` from 31.3.2 to 31.4.0.
Updates `com.android.tools.lint:lint-api` from 31.3.2 to 31.4.0
Updates `com.android.tools.lint:lint` from 31.3.2 to 31.4.0
Updates `com.android.tools.lint:lint-tests` from 31.3.2 to 31.4.0
---
updated-dependencies:
- dependency-name: com.android.tools.lint:lint-api
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.android.tools.lint:lint
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.android.tools.lint:lint-tests
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidGradlePlugin from 8.3.2 to 8.4.0
Bumps `androidGradlePlugin` from 8.3.2 to 8.4.0.
Updates `com.android.application` from 8.3.2 to 8.4.0
Updates `com.android.library` from 8.3.2 to 8.4.0
---
updated-dependencies:
- dependency-name: com.android.application
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.android.library
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* build(deps): bump androidx.activity:activity-ktx from 1.8.2 to 1.9.0 (#16201)
* build(deps): bump androidx.activity:activity-ktx from 1.8.2 to 1.9.0
Bumps androidx.activity:activity-ktx from 1.8.2 to 1.9.0.
---
updated-dependencies:
- dependency-name: androidx.activity:activity-ktx
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* refactor: use activity directly, all ktx extensions in main dep now
Per release notes:
> The remainder of the Activity APIs have been rewritten in Kotlin and
> all extensions previously available in activity-ktx have been moved
> to activity. activity-ktx is now completely empty.
* refactor: handle Intent nullability changes
* fix: [set/add]ContentView nullability change
* fix: onBackPressed deprecation
* fix: further onBackPressed deprecation
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
